gh-7: Add unit tests for pure configuration helpers. - #392
Open
breadonb wants to merge 1 commit into
Open
Conversation
|
All commit authors signed the Contributor License Agreement. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the dependency-free helper functions in
manage.config.Refs #7
Functions tested
config_bool_expand_varsconfig_appendconfig_dict_mergeconfig_splitconfig_split_appendCoverage for
config.pyincreased from 17% to 30%. The full test suite increased from 415 to 456 tests, with all tests passing.The tests satisfy the constraint from the issue by importing the functions directly and passing plain strings and dictionaries. They do not rely on a
pycommand, the filesystem, the registry,_native, or any new dependency.I deliberately scoped this PR to the dependency-free helpers. Tests for
resolve_config,merge_config, and theload_*functions would be a natural follow-up.Tested on Windows with Python 3.14.4 and pytest 9.1.1.
One behavior captured by the tests is that
:is a delimiter forconfig_split, so"C:\\tools"splits into["C", "\tools"]. The testtest_config_split[windows_path]documents the current behavior rather than proposing a change.